removing errormessage block
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyoonie9
requested review from
decentralgabe,
mistermoe,
phoebe-lew,
frankhinek,
nitro-neal,
finn-block and
diehuxx
as code owners
decentralgabe
approved these changes
Apr 1, 2024
|
@leordev and I were discussing introducing CI to the web5-swift repo that factors in downstream projects, this and the tbdex spec submodules might be good candidates for the same treatment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important!
Make sure that if you are updating a test vector that you test in the following repos before merging!
https://github.com/TBD54566975/web5-js
https://github.com/TBD54566975/web5-kt
https://github.com/TBD54566975/web5-swift
Clone each repo locally, make sure that each web5-spec submodule is pointed to your branch, and then run tests to make sure it is still passing in all repos!